fix: abstract image preprocessing in C++ computer vision#376
Merged
JakubGonera merged 7 commits intomainfrom Jun 10, 2025
Merged
fix: abstract image preprocessing in C++ computer vision#376JakubGonera merged 7 commits intomainfrom
JakubGonera merged 7 commits intomainfrom
Conversation
msluszniak
reviewed
Jun 6, 2025
msluszniak
reviewed
Jun 6, 2025
pweglik
reviewed
Jun 6, 2025
Contributor
pweglik
left a comment
pweglik
left a comment
There was a problem hiding this comment.
I like it conceptually, but it's hard for me to review quality-wise
msluszniak
approved these changes
Jun 9, 2025
Member
msluszniak
left a comment
msluszniak
left a comment
There was a problem hiding this comment.
I do not tested manually the changes, but the code looks good!
JakubGonera
force-pushed
the
@jakubgonera/readimage
branch
from
b988a64 to
99f2d79
Compare
mkopcins
pushed a commit
that referenced
this pull request
Oct 15, 2025
## Description Abstract image loading into an Executorch tensor in C++ computer vision native code. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [x] Android ### Related issues #374 ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Abstract image loading into an Executorch tensor in C++ computer vision native code.
Type of change
Tested on
Related issues
#374
Checklist